[
https://issues.apache.org/jira/browse/IGNITE-12028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900012#comment-16900012
]
Andrey Gura commented on IGNITE-12028:
--------------------------------------
[~NSAmelchev] [~NIzhikov]
Guys, could you please avoid in the future javadoc like this:
{code:java}
/** @return Rate time interval in milliseconds. */
public long rateTimeInterval() {
return cntr.rateTimeInterval;
}
{code}
It is public method so javadoc must contain method description and additionaly
{{return tag}}.
> [IEP-35] HitRateMetric should provide rateTimeInterval value to metrics
> exporter
> --------------------------------------------------------------------------------
>
> Key: IGNITE-12028
> URL: https://issues.apache.org/jira/browse/IGNITE-12028
> Project: Ignite
> Issue Type: Improvement
> Reporter: Andrey Gura
> Assignee: Amelchev Nikita
> Priority: Major
> Labels: IEP-35
> Fix For: 2.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{HitRateMetric}} allows to get only counter value while it would be useful
> to get also {{rateTimeInterval}} in order to export this value as part of
> metric name.
> For example look at cache metric {{RebalancingKeysRate}}. Value of this
> measurement could be exported as smth like this:
> {{cache.<cacheName>.RebalancingKeysRate.<rateTimeInterval> = <value>}}.
> So {{HitRateMetric}} should implement {{ObjectMetric}} interface instead of
> {{LongMetric}} interface.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
