[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920508#comment-16920508
]
Saikat Maitra commented on IGNITE-7285:
---------------------------------------
[~Pavlukhin]
# I have modified QueryParameters#fromQuery and moved to QueryParser class.
This will take care of
org.apache.ignite.internal.processors.query.h2.CommandProcessor#processTxCommand.
# This is also taken care as I moved fromQuery method to QueryParser class.
# Can you share an example of how you are thinking to use -1 to indicate user
did not call setTimeout. I was thinking that if user provide
defaultQueryTimeout they may make an assumption that although SqlFieldsQuery
has a timeout value (0) for infinite timeout value the defaultQueryTimeout will
still apply and protect from undesirable system operations.
Please review and share feedback
PR : [https://github.com/apache/ignite/pull/6490/files]
Regards,
Saikat
> Add default query timeout
> -------------------------
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
> Affects Versions: 2.3
> Reporter: Valentin Kulichenko
> Assignee: Saikat Maitra
> Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
