[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947429#comment-16947429
]
Andrey Mashenkov commented on IGNITE-12189:
-------------------------------------------
Yuri,
Check code style test failed due to
[10:00:03][ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheFullTextQuerySelfTest.java:71:
'VARIABLE_DEF' should be separated from previous statement.
[EmptyLineSeparator]
I've found you mark all my PR notes as resolved, but not all of the issue are
actually fixed.
Please, check if you forget to push some changes.
"Queries 1" test results looks weird as they doesn't look flacky and I can't
figure out how your changes can affect them.
Possibly, you've created a branch from quite old master when these tests were
broken.
Please, merge you branch (PR) with the latest master and re-run tests.
> Implement correct limit for TextQuery
> -------------------------------------
>
> Key: IGNITE-12189
> URL: https://issues.apache.org/jira/browse/IGNITE-12189
> Project: Ignite
> Issue Type: Improvement
> Components: general
> Reporter: Yuriy Shuliha
> Assignee: Yuriy Shuliha
> Priority: Major
> Fix For: 2.8
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> PROBLEM
> For now each server-node returns all response records to the client-node and
> it may contain ~thousands, ~hundred thousands records.
> Event if we need only first 10-100. Again, all the results are added to
> queue in _*GridCacheQueryFutureAdapter*_ in arbitrary order by pages.
> There are no any means to deliver deterministic result.
> SOLUTION
> Implement _*limit*_ as parameter for _*TextQuery*_ and
> _*GridCacheQueryRequest*_
> It should be passed as limit parameter in Lucene's
> _*IndexSearcher.search()*_ in _*GridLuceneIndex*_.
> For distributed queries _*limit*_ will also trim response queue when merging
> results.
> Type: long
> Special value: : 0 -> No limit (Integer.MAX_VALUE);
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
