[ https://issues.apache.org/jira/browse/IGNITE-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956947#comment-16956947 ]
Alexander Lapin commented on IGNITE-12305: ------------------------------------------ [~ktkale...@gridgain.com] Looks good to me. > Extend test coverage [IGNITE-11959] NullPointerException If transaction > failed and failure handler doesn't configured explicitly > -------------------------------------------------------------------------------------------------------------------------------- > > Key: IGNITE-12305 > URL: https://issues.apache.org/jira/browse/IGNITE-12305 > Project: Ignite > Issue Type: Improvement > Reporter: Kirill Tkalenko > Assignee: Kirill Tkalenko > Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Test 1. No FH and checking trace of transaction > {quote}org.apache.ignite.internal.processors.cache.SafeLogTxFinishErrorTest#testSafeLogTxFinishErrorWithoutFailureHandler\{quote} > # Start cluster with no FH, load data, start transaction, start and call > \{{activeTx.logTxFinishErrorSafe}} > # Assert that log information doesn’t contains information about FH and no > NPE occurs > # Assert that message starts with \{{Failed completing the transaction: > \[commit=%s, tx=}} and tx_id is correct. > Test 2: FH and checking trace of transaction > {quote}org.apache.ignite.internal.processors.cache.SafeLogTxFinishErrorTest#testSafeLogTxFinishErrorWithFailureHandler\{quote} > # Start cluster with FH, load data, start transaction, start and call > \{{activeTx.logTxFinishErrorSafe}} > # Assert that log information doesn’t contains information about FH and no > NPE occurs > # Assert that message starts with \{{Failed completing the transaction: > \[commit=%s, tx=}} and tx_id is correct. > Test 3: Failed String.format calling from tx > {quote}org.apache.ignite.internal.processors.cache.SafeLogTxFinishErrorTest#testSafeLogTxFinishErrorWithFailureHandlerAndRemoveTxState\{quote} > # Start cluster with FH, load data, start transaction with txState=null, > start and call \{{activeTx.logTxFinishErrorSafe}} > # Assert that log information doesn’t contains information about FH and no > NPE occurs > # Assert that message starts with \{{Failed completing the transaction: > \[commit=%s, tx=}} and tx_id is correct. > -- This message was sent by Atlassian Jira (v8.3.4#803005)