[ 
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969687#comment-16969687
 ] 

Saikat Maitra commented on IGNITE-7285:
---------------------------------------

[~Pavlukhin]

 

Thank you for your feedback.

 

Do you think keeping the change for PlatformConfigurationUtils.java will cause 
regression on the .NET component?

The change I removed is the changes in IgniteConfiguration.cs

I have also created these 2 follow up Jira issues that can be taken up in 
separate PR.

 

https://issues.apache.org/jira/browse/IGNITE-12352

https://issues.apache.org/jira/browse/IGNITE-12354

 

The items excluded from this PR are as follows:

 
 * Update {{SqlFieldsQuery}} and {{QueryOptions}} classes in .NET accordingly - 
set {{Timeout}} to {{TimeSpan.FromMilliseconds(-1)}} by default
 * Full test coverage for those additions is necessary on the .NET part
 * Ignite C++ should be updated as well. I suppose that we should update 
{{query_sql.h}} and {{query_sql_fields.h}}, and pass -1 there as the timeout. 
 * QueryTimeoutException need to be added to differentiate query is cancelled 
due to timeout

 

HTH

Regards,

Saikat

 

> Add default query timeout
> -------------------------
>
>                 Key: IGNITE-7285
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7285
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache, sql
>    Affects Versions: 2.3
>            Reporter: Valentin Kulichenko
>            Assignee: Saikat Maitra
>            Priority: Major
>              Labels: sql-stability
>             Fix For: 2.8
>
>          Time Spent: 10.5h
>  Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be 
> very useful to have default timeout value provided on cache startup. Let's 
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to