[ 
https://issues.apache.org/jira/browse/IGNITE-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ruslan Kuzmin updated IGNITE-12376:
-----------------------------------
    Description: 
Log messages generated when createTcpClient takes more than 
CONNECTION_ESTABLISH_THRESHOLD_MS (100 by default) has INFO level.

It seems it should be changed to WARN level and message text needs to be 
changed for better understanding. 

Message sample (current):

{{2019-11-11 11:11:11.567[INFO 
]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client created 
[client=GridTcpNioCommunicationClient... <output truncated> ]], 
duration=1234ms]}}

 

Proposed format:

{{2019-11-11 11:11:11.567[{color:#ff8b00}WARN{color} 
]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] 
{color:#ff8b00}Long TCP client creation time{color} 
[{color:#ff8b00}threshold=100ms{color}, client=GridTcpNioCommunicationClient... 
<output truncated> ]], duration=1234ms]}}

 

  was:
Log messages generated when createTcpClient takes more than 
CONNECTION_ESTABLISH_THRESHOLD_MS (100 by default) has INFO level.

It seems it should be changed to WARN level and message text needs to be 
changed for better diagnostic and monitoring.

Message sample:

2019-11-11 11:11:11.567[INFO 
]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client created 
[client=GridTcpNioCommunicationClient [ses=GridNioSessionImpl 
[locAddr=/X.X.X.X:12345, rmtAddr=remotehost/X.X.X.X:12345, 
createTime=1572540536563, closeTime=0, bytesSent=0, bytesRcvd=0, bytesSent0=0, 
bytesRcvd0=0, sndSchedTime=1572540536563, lastSndTime=1572540536563, 
lastRcvTime=1572540536563, readsPaused=false, 
filterChain=FilterChain[filters=[, GridConnectionBytesVerifyFilter, SSL 
filter], accepted=false, markedForClose=false]GridSelectorNioSessionImpl 
[worker=GridWorker name=grid-nio-worker-tcp-comm-17, 
igniteInstanceName=nodename, finished=false, hashCode=1608899440, 
interrupted=false, 
runner=grid-nio-worker-tcp-comm-17-nodename-AbstractNioClientWorker [idx=17, 
bytesRcvd=21904021, bytesSent=0, bytesRcvd0=376, bytesSent0=0, select=true, 
super=]DirectNioClientWorker [super=], writeBuf=java.nio.DirectByteBuffer[pos=0 
lim=32768 cap=32768], readBuf=java.nio.DirectByteBuffer[pos=0 lim=32768 
cap=32768], inRecovery=null, outRecovery=GridNioRecoveryDescriptor [acked=0, 
resendCnt=0, rcvCnt=0, sentCnt=9, reserved=true, lastAck=0, nodeLeft=false, 
node=TcpDiscoveryNode [id=abcdefgh-1234-9876-beda-12093498fede, addrs=ArrayList 
[X.X.X.X], sockAddrs=HashSet [host/X.X.X.X:0], discPort=0, order=447, 
intOrder=271, lastExchangeTime=1572288896300, loc=false, 
ver=2.5.1#20190327-sha1:6edfea1b, isClient=true], connected=false, 
connectCnt=112868, queueLimit=4096, reserveCnt=179333, pairedConnections=true], 
super=], super=GridAbstractCommunicationClient [lastUsed=1572540536563, 
closed=false, connIdx=0]], duration=1234ms]


> Change level of "TCP client created ..." log messages to WARN
> -------------------------------------------------------------
>
>                 Key: IGNITE-12376
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12376
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Ruslan Kuzmin
>            Priority: Minor
>
> Log messages generated when createTcpClient takes more than 
> CONNECTION_ESTABLISH_THRESHOLD_MS (100 by default) has INFO level.
> It seems it should be changed to WARN level and message text needs to be 
> changed for better understanding. 
> Message sample (current):
> {{2019-11-11 11:11:11.567[INFO 
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client 
> created [client=GridTcpNioCommunicationClient... <output truncated> ]], 
> duration=1234ms]}}
>  
> Proposed format:
> {{2019-11-11 11:11:11.567[{color:#ff8b00}WARN{color} 
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] 
> {color:#ff8b00}Long TCP client creation time{color} 
> [{color:#ff8b00}threshold=100ms{color}, 
> client=GridTcpNioCommunicationClient... <output truncated> ]], 
> duration=1234ms]}}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to