[ 
https://issues.apache.org/jira/browse/IGNITE-12188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986211#comment-16986211
 ] 

Amelchev Nikita edited comment on IGNITE-12188 at 12/2/19 5:26 PM:
-------------------------------------------------------------------

[~alex_pl], HI, thanks for taking a look.

Yes, that didn't work before. Moreover, this metric will not be reseted when 
{{parallelism lvl=1}} or {{thread idx=0}}, see 
{{SchemaIndexCacheVisitorImpl#visit}} (There is no handler for exceptions from 
{{processPartitions}} in init thread).

Should we fix it in this issue?


was (Author: nsamelchev):
[~alex_pl], HI, thanks for taking a look.

Yes, that didn't work before. Moreover, this metric will not be reseted when 
{{parallelism lvl=1}} or {{thread idx=0}}, see 
{{SchemaIndexCacheVisitorImpl#visit}} (There is no handler for exceptions from 
{{processPartitions}} in init thread).

Should we fix this in this issue?

> Metric CacheGroupMetrics.IndexBuildCountPartitionsLeft doesn't work correctly 
> if there is more then one cache in cache group
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-12188
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12188
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.8
>            Reporter: Aleksey Plekhanov
>            Assignee: Amelchev Nikita
>            Priority: Major
>              Labels: IEP-35, await
>             Fix For: 2.8
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Initial partitions counter is set to a total number of partitions for cache 
> group but decremented each time partition processed for each cache.
> Reproducer:
> {code:java}
>     @Test
>     public void testIndexRebuildMetrics() throws Exception {
>         IgniteEx ignite = startGrid(new IgniteConfiguration()
>             .setConsistentId("ignite")
>             .setDataStorageConfiguration(new DataStorageConfiguration()
>                 .setDefaultDataRegionConfiguration(new 
> DataRegionConfiguration().setPersistenceEnabled(true)))
>             .setCacheConfiguration(
>                 new CacheConfiguration<Integer, 
> Integer>("c1").setGroupName("grp").setIndexedTypes(Integer.class, 
> Integer.class),
>                 new CacheConfiguration<Integer, 
> Integer>("c2").setGroupName("grp").setIndexedTypes(Integer.class, 
> Integer.class)
>             ));
>         ignite.cluster().active(true);
>         for (int i = 0; i < 10_000; i++)
>             ignite.cache("c1").put(i, i);
>         ignite.cluster().active(false);
>         File dir = U.resolveWorkDirectory(U.defaultWorkDirectory(), 
> DFLT_STORE_DIR, false);
>         U.delete(new File(dir, "ignite/cacheGroup-grp/index.bin"));
>         ignite.cluster().active(true);
>         doSleep(1_000L);
>         
> assertTrue(ignite.context().cache().cache("c1").context().group().metrics().getIndexBuildCountPartitionsLeft()
>  >= 0);
>     }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to