[ 
https://issues.apache.org/jira/browse/IGNITE-11857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989525#comment-16989525
 ] 

Alexei Scherbakov commented on IGNITE-11857:
--------------------------------------------

[~alex_pl]

I've looked at your contribution.

Changing TreeSet to TreeMap looks like a very minor change. I think you can go 
further and get rid of Item class. Out of order updates can be kept in 
SortedMap<Long, Long> where key is a start and value is a range (or even in 
sorted array of primitive tuples). Another possibility is storing missing 
updates in a bitmap.

You should also check a new solution for heap usage in comparison to the old. 
For many partitions configurations less heap usage could be more significant 
advantage other the minor performance boost.

Also I have a little concern about the robustness of a fix. It might be risky 
to merge it to 2.8 without extensive testing.

So, I would postpone the change and improved the patch first.



> Investigate performance drop after IGNITE-10078
> -----------------------------------------------
>
>                 Key: IGNITE-11857
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11857
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Alexei Scherbakov
>            Assignee: Aleksey Plekhanov
>            Priority: Major
>         Attachments: ignite-config.xml, 
> run.properties.tx-optimistic-put-b-backup
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> After IGNITE-10078 yardstick tests show performance drop up to 8% in some 
> scenarios:
> * tx-optim-repRead-put-get
> * tx-optimistic-put
> * tx-putAll
> Partially this is due new update counter implementation, but not only. 
> Investigation is required.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to