[ 
https://issues.apache.org/jira/browse/IGNITE-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989706#comment-16989706
 ] 

Anton Vinogradov edited comment on IGNITE-6804 at 12/6/19 12:34 PM:
--------------------------------------------------------------------

Folks, 
A warning will be ignored.
Javadoс will be ignored too.

We should just perform instanceOf check inside the putAll() method if 
pessimistic.
Such check will not drop overall performance since it will be evaluated on the 
client node.

BTW, Can we perform same check by some annotation-based contract using static 
analysis?



was (Author: avinogradov):
Folks, 
A warning will be ignored.
Javadoс will be ignored too.

We should just perform instanceOf check inside the putAll() method if 
pessimistic.
Such check will not drop overall performance since it will be evaluated on the 
client node.

BTW, Can we perform same check by some annotation contract using static 
analysis?


> Print a warning if HashMap is passed into bulk update operations
> ----------------------------------------------------------------
>
>                 Key: IGNITE-6804
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6804
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache
>            Reporter: Denis A. Magda
>            Assignee: Ilya Kasnacheev
>            Priority: Critical
>              Labels: usability
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Ignite newcomers tend to stumble on deadlocks simply because the keys are 
> passed in an unordered HashMap. Propose to do the following:
> * update bulk operations Java docs.
> * print out a warning if not SortedMap (e.g. HashMap, 
> Weak/Identity/Concurrent/Linked HashMap etc) is passed into
> a bulk method (instead of SortedMap) and contains more than 1 element. 
> However, we should make sure that we only print that warning once and not 
> every time the API is called.
> * do not produce warning for explicit optimistic transactions
> More details are here:
> http://apache-ignite-developers.2346864.n4.nabble.com/Re-Ignite-2-0-0-GridUnsafe-unmonitor-td23706.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to