[ 
https://issues.apache.org/jira/browse/IGNITE-12049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999316#comment-16999316
 ] 

Alexey Scherbakov commented on IGNITE-12049:
--------------------------------------------

[~SomeFire]

Overall looks good. My questions:

1. Can you explain how this works for you:
BinaryContext ctx = new BinaryContext(BinaryCachingMetadataHandler.create(), 
new IgniteConfiguration(), null);
BinaryWriterExImpl writer = new BinaryWriterExImpl(ctx, new 
BinaryHeapOutputStream(32), null, null);
...
writer.writeMap(..)
For me this throws an exception because a marshaller context is null.

2. The TC bot visa is missing.

3. Shouldn't we rename userAttributes to userAttributesFactory ?

> Add user attributes to thin clients
> -----------------------------------
>
>                 Key: IGNITE-12049
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12049
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Ryabov Dmitrii
>            Assignee: Ryabov Dmitrii
>            Priority: Minor
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Add user attributes to thin clients (like node attributes for server nodes). 
> Make sure that custom authenticators can use these attributes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to