[
https://issues.apache.org/jira/browse/IGNITE-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999930#comment-16999930
]
Andrey Mashenkov edited comment on IGNITE-12167 at 12/19/19 10:19 AM:
----------------------------------------------------------------------
May be we can
1. avoid pageHndWrapper usage in BTree constructor directly.
2. e.g. introduce wrap() method that will be ok with pageHndWrapper=null value.
3. make pageHndWrapper *non-volatile* as there is no need to have it volatile.
4. rename pageHndWrapper -> testHndWrapper.
5. add an *assert BPlusTree. testHndWrapper==null;* in beforeTestsStarted.
What do you think?
was (Author: amashenkov):
May be we can avoid pageHndWrapper usage in BTree constructor directly.
E.g. introduce wrap() method that will be ok with pageHndWrapper=null value.
Also it make no sense to have *volatile* pageHndWrapper.
What do you think?
> Move resetting of BPlusTree.pageHndWrapper to GridAbstractTest
> --------------------------------------------------------------
>
> Key: IGNITE-12167
> URL: https://issues.apache.org/jira/browse/IGNITE-12167
> Project: Ignite
> Issue Type: Improvement
> Reporter: Denis Chudov
> Assignee: Denis Chudov
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should move logic for clearing custom pageHndWrapperin
> {{afterTestsStopped()}} in {{GridCommonAbstractTest}} or {{GridAbstractTest
> to ensure that we will not have problems in any tests which set custom
> wrapper}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
