[
https://issues.apache.org/jira/browse/IGNITE-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032460#comment-17032460
]
Ivan Rakov commented on IGNITE-12628:
-------------------------------------
[~vmalinovskiy] Vladimir, hello!
Please pay attention to the Ignite code style.
{code:java}
Set<String> beancClsNames = srv.queryMBeans(null, null).stream()
.map(ObjectInstance::getClassName)
.collect(toSet());
{code}
Ident for next lines in a long expression is 4 bytes.
{code:java}
try {
Ignite ignite = startGrid();
validateMbeans(ignite,
"org.apache.ignite.spi.discovery.zk.ZookeeperDiscoverySpi$ZookeeperDiscoverySpiMBeanImpl");
}
finally {
stopAllGrids();
}
{code}
finally and catch clauses should be on a separate line.
> Add tests for jmx metrics return types
> --------------------------------------
>
> Key: IGNITE-12628
> URL: https://issues.apache.org/jira/browse/IGNITE-12628
> Project: Ignite
> Issue Type: Bug
> Reporter: Vladimir Malinovskiy
> Assignee: Vladimir Malinovskiy
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add tests than check if JMX metrics comply with Oracle best
> practices([https://www.oracle.com/technetwork/java/javase/tech/best-practices-jsp-136021.html])
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
