[
https://issues.apache.org/jira/browse/IGNITE-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034380#comment-17034380
]
Taras Ledkov commented on IGNITE-12609:
---------------------------------------
[~amashenkov], the patch is OK with me.
> SQL: GridReduceQueryExecutor refactoring.
> -----------------------------------------
>
> Key: IGNITE-12609
> URL: https://issues.apache.org/jira/browse/IGNITE-12609
> Project: Ignite
> Issue Type: Task
> Components: sql
> Reporter: Andrey Mashenkov
> Assignee: Andrey Mashenkov
> Priority: Major
> Labels: refactoring
> Time Spent: 10m
> Remaining Estimate: 0h
>
> For now we have few issues that can be resolved.
> 1. We create fake H2 tables\indices for reduce stage even if there is no need
> to do so (skipMergeTable=true.
> Let's decouple reduce logic from H2Index adapter code.
> 2. Partition mapping code look to complicated and non-optimal.
> Let's use cached affinity mapping and avoid collections copying when possible.
> 3. Also there is no sense to pass RequestID to mapping code just for logging.
> We'll never be able to match any request as no query really exists at a time
> when error with RequestID is logged.
> 4. Replicated only flag value semantic (calculation and usage) is not clear.
> 5. GridReduceQueryExecutor.reduce() method is too long (over 400 lines).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
