[ 
https://issues.apache.org/jira/browse/IGNITE-12728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049083#comment-17049083
 ] 

Amelchev Nikita edited comment on IGNITE-12728 at 3/2/20 10:40 AM:
-------------------------------------------------------------------

I fixed metrics for the {{cache#putAllAsync}} method. Did it the same way as 
collecting statistics in {{getAll}}, {{getAllAsync}}, {{removeAll}}, 
{{removeAllAsync}} methods.

[~alex_pl], could you take a look, please?


was (Author: nsamelchev):
I fixed the collection of metrics for the {{cache#putAllAsync}} method. Did it 
the same way as collecting statistics in {{getAll}}, {{getAllAsync}}, 
{{removeAll}}, {{removeAllAsync}} methods.

[~alex_pl], could you take a look, please?

> The cache#putAllAsync method does not collect statistics
> --------------------------------------------------------
>
>                 Key: IGNITE-12728
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12728
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Amelchev Nikita
>            Assignee: Amelchev Nikita
>            Priority: Major
>              Labels: IEP-35
>             Fix For: 2.9
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The cache#putAllAsync method does not collect statistics.
> The reproducer for {{GridCacheAbstractMetricsSelfTest}}:
> {noformat}
>     @Test
>     public void testPutAllAsyncAvgTime() throws Exception {
>         IgniteCache<Integer, Integer> cache = 
> grid(0).cache(DEFAULT_CACHE_NAME);
>         assertEquals(0.0, cache.localMetrics().getAveragePutTime(), 0.0);
>         assertEquals(0, cache.localMetrics().getCachePuts());
>         Map<Integer, Integer> values = new HashMap<>();
>         values.put(1, 1);
>         values.put(2, 2);
>         values.put(3, 3);
>         IgniteFuture<Void> fut = cache.putAllAsync(values);
>         fut.get();
>         assertTrue(waitForCondition(() -> 
> cache.localMetrics().getAveragePutTime() > 0, 30_000));
>         assertEquals(values.size(), cache.localMetrics().getCachePuts());
>     }
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to