[
https://issues.apache.org/jira/browse/IGNITE-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053459#comment-17053459
]
Andrey N. Gura commented on IGNITE-12756:
-----------------------------------------
I already run test using other branch and PR so change could be reviewed while
I am trying to get new visa.
> TcpCommunicationSpi metrics implementation improvements
> --------------------------------------------------------
>
> Key: IGNITE-12756
> URL: https://issues.apache.org/jira/browse/IGNITE-12756
> Project: Ignite
> Issue Type: Improvement
> Reporter: Andrey N. Gura
> Assignee: Andrey N. Gura
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Implementation of IGNITE-12682 allows now to create sent/received counters by
> message direct type statically during SPI initialization. Data structure for
> this counters does have any contention so we can remove thread local
> HashMap's for this counters. As result we will also reduce memory footprint
> (we can use IntHashMap which is more memory effective and we will have only
> one map instance instead of map per thread).
> Also there is a couple of problems which could be solved during
> implementation this issue:
> - SPI uses internal API while we should extend IgniteSpiContext that will
> provide access to the {{GridMEtricManager}} functionality.
> - {{MetricManagerResource}} annotation is redundant and has only one usage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
