[ 
https://issues.apache.org/jira/browse/IGNITE-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Steshin updated IGNITE-12773:
--------------------------------------
    Description: 
To reduce number of cluster deactivation methods in internal API we might:

{code:java}
1.      Remove
GridClientClusterState#active()

2.      Remove
GridClientClusterState#active(boolean active)

3.      Remove
IGridClusterStateProcessor#changeGlobalState(
    boolean activate,
    Collection<? extends BaselineNode> baselineNodes,
    boolean forceChangeBaselineTopology
)

4.      Remove
GridClusterStateProcessor#changeGlobalState(
    final boolean activate,
    Collection<? extends BaselineNode> baselineNodes,
    boolean forceChangeBaselineTopology,
    boolean isAutoAdjust
)

5.      Remove
GridClusterStateProcessor#changeGlobalState(
    final boolean activate,
    Collection<? extends BaselineNode> baselineNodes,
    boolean forceChangeBaselineTopology
)

6.      Remove 
GridClusterStateProcessor#changeGlobalState(
    ClusterState state,
    Collection<? extends BaselineNode> baselineNodes,
    boolean forceChangeBaselineTopology
)

7.      Add boolean isAutoAdjust to 
IGridClusterStateProcessor#changeGlobalState(
    ClusterState state,
    Collection<? extends BaselineNode> baselineNodes,
    boolean forceChangeBaselineTopology,
   /* here */ boolean isAutoAdjust /* here */
)

8.      Add @Override to 
/* here */ @Override /* here */
IGridClusterStateProcessor#changeGlobalState(
        ClusterState state,
        Collection<? extends BaselineNode> baselineNodes,
        boolean forceChangeBaselineTopology,
        boolean isAutoAdjust
    )

9.      Remove, combine with #8:
private IgniteInternalFuture<?> changeGlobalState0(
        ClusterState state,
        BaselineTopology blt,
        boolean forceChangeBaselineTopology,
        boolean isAutoAdjust
    ) 
{code}


  was:
To reduce number of cluster deactivation methods in internal API we might:

{code:java}
1.      Remove
GridClientClusterState#active()

2.      Remove
GridClientClusterState#active(boolean active)

3.      Remove
IGridClusterStateProcessor#changeGlobalState(
    boolean activate,
    Collection<? extends BaselineNode> baselineNodes,
    boolean forceChangeBaselineTopology
)

4.      Remove
GridClusterStateProcessor#changeGlobalState(
    final boolean activate,
    Collection<? extends BaselineNode> baselineNodes,
    boolean forceChangeBaselineTopology,
    boolean isAutoAdjust
)

5.      Remove
GridClusterStateProcessor#changeGlobalState(
    final boolean activate,
    Collection<? extends BaselineNode> baselineNodes,
    boolean forceChangeBaselineTopology
)

6.      Remove 
GridClusterStateProcessor#changeGlobalState(
    ClusterState state,
    Collection<? extends BaselineNode> baselineNodes,
    boolean forceChangeBaselineTopology
)

7.      Add boolean isAutoAdjust to 
IGridClusterStateProcessor#changeGlobalState(
    ClusterState state,
    Collection<? extends BaselineNode> baselineNodes,
    boolean forceChangeBaselineTopology,
   /* here */ boolean isAutoAdjust /* here */
)

8.      Add @Override to 
/* here */ @Override /* here */
IGridClusterStateProcessor#changeGlobalState(
        ClusterState state,
        boolean forceDeactivation,
        Collection<? extends BaselineNode> baselineNodes,
        boolean forceChangeBaselineTopology,
        boolean isAutoAdjust
    )

9.      Remove, combine with #8:
private IgniteInternalFuture<?> changeGlobalState0(
        ClusterState state,
        BaselineTopology blt,
        boolean forceChangeBaselineTopology,
        boolean isAutoAdjust
    ) 
{code}



> Reduce number of cluster deactivation methods in internal API.
> --------------------------------------------------------------
>
>                 Key: IGNITE-12773
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12773
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Vladimir Steshin
>            Assignee: Vladimir Steshin
>            Priority: Minor
>
> To reduce number of cluster deactivation methods in internal API we might:
> {code:java}
> 1.    Remove
> GridClientClusterState#active()
> 2.    Remove
> GridClientClusterState#active(boolean active)
> 3.    Remove
> IGridClusterStateProcessor#changeGlobalState(
>     boolean activate,
>     Collection<? extends BaselineNode> baselineNodes,
>     boolean forceChangeBaselineTopology
> )
> 4.    Remove
> GridClusterStateProcessor#changeGlobalState(
>     final boolean activate,
>     Collection<? extends BaselineNode> baselineNodes,
>     boolean forceChangeBaselineTopology,
>     boolean isAutoAdjust
> )
> 5.    Remove
> GridClusterStateProcessor#changeGlobalState(
>     final boolean activate,
>     Collection<? extends BaselineNode> baselineNodes,
>     boolean forceChangeBaselineTopology
> )
> 6.    Remove 
> GridClusterStateProcessor#changeGlobalState(
>     ClusterState state,
>     Collection<? extends BaselineNode> baselineNodes,
>     boolean forceChangeBaselineTopology
> )
> 7.    Add boolean isAutoAdjust to 
> IGridClusterStateProcessor#changeGlobalState(
>     ClusterState state,
>     Collection<? extends BaselineNode> baselineNodes,
>     boolean forceChangeBaselineTopology,
>    /* here */ boolean isAutoAdjust /* here */
> )
> 8.    Add @Override to 
> /* here */ @Override /* here */
> IGridClusterStateProcessor#changeGlobalState(
>         ClusterState state,
>         Collection<? extends BaselineNode> baselineNodes,
>         boolean forceChangeBaselineTopology,
>         boolean isAutoAdjust
>     )
> 9.      Remove, combine with #8:
> private IgniteInternalFuture<?> changeGlobalState0(
>         ClusterState state,
>         BaselineTopology blt,
>         boolean forceChangeBaselineTopology,
>         boolean isAutoAdjust
>     ) 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to