[ 
https://issues.apache.org/jira/browse/IGNITE-12799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061760#comment-17061760
 ] 

Vyacheslav Koptilin edited comment on IGNITE-12799 at 3/18/20, 2:19 PM:
------------------------------------------------------------------------

Hello [~schernolyas],

I am not an expert in spring data at all. However, I have the following 
question:
 IGNITE-12582 contains new tests and it is verified by TC Boat (has a green 
visa). Does it mean there are no tests that cover the bug you are trying to fix 
in this pull-request?

Could you please add to the description the reason why 
\{#cacheNames.personCacheName} should be used instead of 
\{@cacheNames.personCacheName}?

Thanks,
 S.


was (Author: slava.koptilin):
Hello [~schernolyas],

I am not an expert in spring data at all. However, I have the following 
question:
IGNITE-12582 contains new tests and it is verified by TC Boat (has a green 
visa). Does it mean there are no tests that cover the bug you are trying to fix 
in this pull-request?

Thanks,
S.

> Set right SpEL at Spring Data tests
> -----------------------------------
>
>                 Key: IGNITE-12799
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12799
>             Project: Ignite
>          Issue Type: Bug
>          Components: spring
>    Affects Versions: 2.8.1
>            Reporter: Sergey Chernolyas
>            Assignee: Sergey Chernolyas
>            Priority: Trivial
>             Fix For: 2.8.1
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> PersonExpressionRepository usesĀ  SpEL "@cacheNames.personCacheName". It is 
> wrong. SpEL "#\{cacheNames.personCacheName}" must be used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to