[ 
https://issues.apache.org/jira/browse/IGNITE-12769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061788#comment-17061788
 ] 

Andrey N. Gura commented on IGNITE-12769:
-----------------------------------------

[~nizhikov] {{MetricRegistry}} still allows to remove any metrics. If somebody 
remove histogram metric {{histrogramNames}} caches will still contain key-value 
pair for removed histogram.

I don't see any reason for {{histogramNames}} cache at all. For 
{{MetricRegistryMBean}} each invocation of {{getAttribute}} attribute method 
will still produce garbage which is comparable with concatenation of metric 
name and bounds.
If we remove this cache we will also fix IGNITE-12767 automatically. Moreover, 
we will fix design problem where {{MetricUtils}} is responsible for histogram 
metric name representation instead of corresponding exporter.

> MetricRegistryMBean and OpenCensusExporterSpi have memory leak
> --------------------------------------------------------------
>
>                 Key: IGNITE-12769
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12769
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Andrey N. Gura
>            Assignee: Nikolay Izhikov
>            Priority: Major
>             Fix For: 2.8.1
>
>
> {{MetricRegistryMBean}} and {{OpenCensusExporterSpi}} have memory leak. 
> To the following maps values add but never remove (i.e. on remove 
> corresponding histogram or on change histogram buckets layout):
> * {{MetricRegistryMBean.histogramNames}}
> * {{OpenCensusMetricExporterSpi.histogramNames}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to