[ https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17062365#comment-17062365 ]
Taras Ledkov edited comment on IGNITE-8152 at 3/19/20, 8:26 AM: ---------------------------------------------------------------- [~Aleksei_Litsov], the patch is OK with me. Please fix minor codestyle: 1. {{H2ConnectionWrapper#connection(java.lang.String)}} empty string 2. javadoc for {{BaseSqlTest#executeFrom(java.lang.String, org.apache.ignite.Ignite, java.lang.String)}} What about tests visa from TC Bot? was (Author: tledkov-gridgain): [~Aleksei_Litsov], the patch is OK with me. Please fix minor codestyle: 1. {{H2ConnectionWrapper#connection(java.lang.String)}} empty string 2. javadoc for {{BaseSqlTest#executeFrom(java.lang.String, org.apache.ignite.Ignite, java.lang.String)}} > Forbid empty sql schema name > ---------------------------- > > Key: IGNITE-8152 > URL: https://issues.apache.org/jira/browse/IGNITE-8152 > Project: Ignite > Issue Type: Improvement > Components: sql > Reporter: Pavel Kuznetsov > Assignee: Alexey > Priority: Major > Labels: newbie > Time Spent: 2.5h > Remaining Estimate: 0h > > Currently we allow empty schema name (quoted) in cache configuration > org.apache.ignite.configuration.CacheConfiguration#setSqlSchema : > {noformat} > When sqlSchema is not specified, quoted cacheName is used instead. > sqlSchema could not be an empty string. Has to be "\"\"" instead. > Params: > sqlSchema - Schema name for current cache according to SQL ANSI-99. Should > not be null. > {noformat} > Specifying schema \"\" results in empty string schema name. > No schema in sql query is treated as PUBLIC, but \"\" is regular schema name. > It's better to disallow usage of \"\" schema -- This message was sent by Atlassian Jira (v8.3.4#803005)