[
https://issues.apache.org/jira/browse/IGNITE-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579238#comment-14579238
]
Andrey Gura edited comment on IGNITE-428 at 6/9/15 5:22 PM:
------------------------------------------------------------
[~Vishal.garg.ignite], thanks a lot for your implementation.
Some comments to your patch:
1. Please look at Ignite Coding Guidelines
(https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines) and make
sure that your code satisfies to it. Pay attention to javadoc, brackets, lines
breaks and indentation, naming and abbreviation, imports.
2. Move your {{KafkaStreamer}} implementation and corresponding tests to
{{org.apache.ignite.stream.kafka}} package (similar to {{SocketStreamer}}).
3. Please, remove unused code, and move {{createDefaultConsumerConfig}}
method into test..
4. {{KafkaIgniteStreamerTest}} should be renamed to {{KafkaStreamerSelfTest}}.
5. {{KafkaIgniteStreamerTest}} isn't stable and sometimes fails. The problem
in {{produceStream}} method: {{rnd.nextInt(255)}} could produce repeating
values and it lead to rewriting some keys.
6. Add new {{ignite-kafka}} module into root {{pom.xml}} file.
was (Author: agura):
[~Vishal.garg.ignite], thanks a lot for your implementation.
Some comments to your patch:
1. Please look at Ignite Coding Guidelines
(https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines) and make
sure that your code satisfies to it. Pay attention to javadoc, brackets, lines
breaks and indentation, naming and abbreviation, imports.
2. Move your {{KafkaStreamer}} implementation and corresponding tests to
{{org.apache.ignite.stream.kafka}} package (similar to {{SocketStreamer}}).
3. Please, remove unused code, and move {{createDefaultConsumerConfig}}
method into test..
4. {{KafkaIgniteStreamerTest}} should be renamed to {{KafkaStreamerSelfTest}}.
5. {{KafkaIgniteStreamerTest}} isn't stable and sometimes fails. The problem
in {{produceStream}} method: {{rnd.nextInt(255)}} could produce repeating
values and it lead to rewriting some keys.
> Implement IgniteKafkaStreamer to stream data from Apache Kafka
> --------------------------------------------------------------
>
> Key: IGNITE-428
> URL: https://issues.apache.org/jira/browse/IGNITE-428
> Project: Ignite
> Issue Type: Sub-task
> Components: streaming
> Affects Versions: sprint-5
> Reporter: Dmitriy Setrakyan
> Assignee: Andrey Gura
> Attachments: ignite-sprint-5_ignite-428.patch
>
>
> We have {{IgniteDataStreamer}} which is used to load data into Ignite under
> high load. It was previously named {{IgniteDataLoader}}, see ticket
> IGNITE-394.
> See [Apache Kafka|http://kafka.apache.org/] for more information.
> We should create {{IgniteKafkaStreamer}} which will consume messages from
> Kafka and stream them into Ignite caches.
> More details to follow, but to the least we should be able to:
> - Convert Kafka messages to Ignite data using an optional pluggable converter.
> - Specify the cache name for the Ignite cache to load data into.
> - Specify other flags available on {{IgniteDataStreamer}} class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
