[
https://issues.apache.org/jira/browse/IGNITE-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595865#comment-14595865
]
Atri Sharma commented on IGNITE-1006:
-------------------------------------
Hi Artem,
Thanks for your review.
Please see my comments below:
1) I did not see clean way of working with ClusterGroupAdapter#nodes since
specific operations have to be executed in each step (I agree that logic flow
for both functions is same). Please advice on this.
2) I could not locate test for ClusterGroupAdapter#nodes hence did not add
corresponding test for hostnames(). Please advice on the location.
> Add hostnames() method to ClusterGroup to get all hostnames in current
> ClusterGroup
> -----------------------------------------------------------------------------------
>
> Key: IGNITE-1006
> URL: https://issues.apache.org/jira/browse/IGNITE-1006
> Project: Ignite
> Issue Type: Task
> Reporter: Atri Sharma
> Assignee: Atri Sharma
> Attachments: ignite-sprint-5_ignite-1006ver1.patch
>
>
> We should have method like nodes() in ClusterGroup to allow getting all
> hostnames currently in this ClusterGroup. Method should ensure handling for
> duplicates as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
