[
https://issues.apache.org/jira/browse/IGNITE-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexey Kuznetsov reassigned IGNITE-1121:
----------------------------------------
Assignee: Sergey Evdokimov (was: Alexey Kuznetsov)
Sergey, I reviewed code. Please fix following issues.
1. Please add comments to config.properties and logging.properties
2. Add README.txt about with short description of module and how to build it
(mvn command).
3. Create agent.bat (you created only agent.sh)
4. Almost all classes have no javadocs or invalid javadocs (no @return or
@param).
5. AgentLauncher: 114 exception of Thread.sleep is not handled.
6. AgentLauncher: 60 variable cmd is never used.
7. Agent: 42 variable httpclient should be named httpClient
8. It seems that file "config.properties" will be located inside jar? It is
very uncomfortable to change settings in production.
9. Why AbstractMessage is a abstract class and not interface?
10. Agent: 103 "nvps.size() > 0" should be replaces "!nvps.isEmpty()"
> Implementation of control-center-agent as proxy between web-server and Ignite
> cluster
> -------------------------------------------------------------------------------------
>
> Key: IGNITE-1121
> URL: https://issues.apache.org/jira/browse/IGNITE-1121
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Sergey Evdokimov
> Assignee: Sergey Evdokimov
>
> We need to implement web-agent that will work like a proxy between web-server
> and Ignite cluster to:
> 1) collect metrics for grid monitoring
> 2) execute sql queries
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
