[ 
https://issues.apache.org/jira/browse/IGNITE-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681621#comment-14681621
 ] 

Denis Magda commented on IGNITE-946:
------------------------------------

Alexey, thanks a lot for taking look at this and leaving suggestions.

I followed your inputs and did the following:
- simplified {{VersionedEntry}} interface as you suggested;
- fixed topology version related bugs in {{GridCacheVersionManager}}.

Please briefly review the changes. There is no need for a deep review, it was 
done by Yakov before.
Validated all the changes with TC.

BTW, at this moment {{VersionedEntry}} interface looks like this.
{noformat}
public interface VersionedEntry<K, V> extends Cache.Entry<K, V> {
    /**
     * Returns a comparable object representing the version of this cache entry.
     * <p>
     * It is valid to compare cache entries' versions for the same key. In this 
case the latter update will be
     * represented by a higher version. The result of versions comparison of 
cache entries of different keys is
     * undefined.
     *
     * @return Version of this cache entry.
     */
    public Comparable version();

    /**
     * Returns the time when the cache entry for the given key has been updated 
or initially created.
     * <p>
     * It is valid to compare cache entries' update time for the same key. In 
this case the latter update will
     * be represented by higher update time. The result of update time 
comparison of cache entries of different keys is
     * undefined.
     *
     * @return Time in milliseconds.
     */
    public long updateTime();
}
{noformat} 

> Need to expose versioned cache entry to public API
> --------------------------------------------------
>
>                 Key: IGNITE-946
>                 URL: https://issues.apache.org/jira/browse/IGNITE-946
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: sprint-4
>            Reporter: Valentin Kulichenko
>            Assignee: Denis Magda
>            Priority: Critical
>              Labels: Usability
>             Fix For: ignite-1.4
>
>         Attachments: ignite-946-2.patch, ignite-946-3.patch, 
> ignite-946-4.patch, ignite-946.patch
>
>
> Currently we have versioned entry, but it's not available on public API, but 
> knowing version can be useful in some cases. Need to make it accessible via 
> {{unwrap}} method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to