[ 
https://issues.apache.org/jira/browse/IMPALA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fredy Wijaya resolved IMPALA-6809.
----------------------------------
       Resolution: Done
    Fix Version/s: Impala 2.12.0
                   Impala 3.0

> bootstrap_system.sh does an unconditional git clone to ~/Impala
> ---------------------------------------------------------------
>
>                 Key: IMPALA-6809
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6809
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 2.11.0
>            Reporter: Gabor Kaszab
>            Assignee: Fredy Wijaya
>            Priority: Major
>             Fix For: Impala 3.0, Impala 2.12.0
>
>
> bootstrap_system.sh checks if ~/Impala is an existing directory, and if it 
> isn't then clones Impala to that path. Once this is done this script jumps to 
> ~/Impala and starts a build.
> In case someone clones the Impala sources to a custom directory, sources the 
> Impala configs there and then invokes bootstrap_development.sh or 
> bootstrap_system.sh then in the background the build is actually performed in 
> ~/Impala instead of the custom dir. Taking into account that Impala is not 
> sourced from ~/Impala, but the build is done there, this can result some 
> strange build failures.
> My proposal is to move the following code behind a command line parameter 
> that is off by default:
> {code:java}
> # If there is no Impala git repo, get one now
> if ! [[ -d ~/Impala ]]
> then
>   time -p git clone https://git-wip-us.apache.org/repos/asf/impala.git 
> ~/Impala
> fi
> cd ~/Impala
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to