[
https://issues.apache.org/jira/browse/IMPALA-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Tauber-Marshall resolved IMPALA-6845.
--------------------------------------------
Resolution: Fixed
commit 16bed5c3a91d2575e1a0d3327735df15d51b5bf6
Author: Thomas Tauber-Marshall <[email protected]>
Date: Thu Apr 12 23:11:05 2018 +0000
IMPALA-6845: TestHdfsQueries causes some tests to be run twice
TestHdfsQueries is a subclass of TestQueries and inherits of all its
'test_*' methods, causing these tests to be run twice any time
test_queries.py is run. This was not intentional (it was subclassed
just to inherit 'add_test_dimensions') and causes test runs to take
longer than necessary.
This patch removes the subclass relationship and copies the logic in
add_test_dimensions() from TestQueries in HdfsTestQueries, with a
convenience function added to minimize code duplication.
Testing:
- Ran test_queries.py under both 'core' and 'exhaustive' and checked
that the same tests are run, except all now only a single time each.
Change-Id: Ida659aa7b5131a6a7469baa93a41f7581bd0659a
Reviewed-on: http://gerrit.cloudera.org:8080/10053
Reviewed-by: Michael Brown <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> TestHdfsQueries causes some tests to be run twice
> -------------------------------------------------
>
> Key: IMPALA-6845
> URL: https://issues.apache.org/jira/browse/IMPALA-6845
> Project: IMPALA
> Issue Type: Bug
> Reporter: Thomas Tauber-Marshall
> Assignee: Thomas Tauber-Marshall
> Priority: Major
>
> TestHdfsQueries is a subclass of TestQueries and inherits of all its 'test_*'
> methods, causing these tests to be run twice any time test_queries.py is run.
> This was not intentional (it was subclassed just to inherit
> 'add_test_dimensions') and causes test runs to take longer than necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
