[
https://issues.apache.org/jira/browse/IMPALA-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Armstrong resolved IMPALA-3637.
-----------------------------------
Resolution: Later
> Merge codegen constant replacement mechanisms
> ---------------------------------------------
>
> Key: IMPALA-3637
> URL: https://issues.apache.org/jira/browse/IMPALA-3637
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 2.6.0
> Reporter: Tim Armstrong
> Priority: Minor
> Labels: codegen
>
> We currently have two similar way to replace constants in codegen'd code:
> Expr::GetConstant() and LlvmCodeGen::ReplaceCallSitesWithBoolConst(). We
> should merge them so that we have a single mechanism with the functionality
> of both.
> E.g.
> A version that takes a map where the key is a symbol and the value is a
> constant, or a vector of constants:
> ReplaceCallSitesWithConstants(Function* map, <string, ConstantInfo>*)
> We could then avoid the expensive Expr::GetConstant() call on the interpreted
> path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
