Joe McDonnell created IMPALA-10375:
--------------------------------------

             Summary: Lock down which filesystem types can claim to be local 
for file handle cache
                 Key: IMPALA-10375
                 URL: https://issues.apache.org/jira/browse/IMPALA-10375
             Project: IMPALA
          Issue Type: Bug
          Components: Backend
    Affects Versions: Impala 4.0
            Reporter: Joe McDonnell


When determining whether to cache file handles, the code uses this check:
{noformat}
bool use_file_handle_cache = false;
if (is_file_handle_caching_enabled() &&
    (expected_local_ ||
     (FLAGS_cache_remote_file_handles && disk_id_ == 
io_mgr_->RemoteDfsDiskId()) ||
     (FLAGS_cache_s3_file_handles && disk_id_ == io_mgr_->RemoteS3DiskId()) ||
     (FLAGS_cache_abfs_file_handles && disk_id_ == 
io_mgr_->RemoteAbfsDiskId())) {
  use_file_handle_cache = true;
}{noformat}
If expected_local_ is specified, then we always would allow caching, regardless 
of filesystem type. While expected_local_ should be false for remote 
filesystems, the code should be more defensive and only let expected_local_ 
apply to filesystems that are supported as local. In particular, we currently 
don't support caching Ozone file handles, but if this somehow considered Ozone 
local, then it would cache them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to