[
https://issues.apache.org/jira/browse/IMPALA-10374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Riza Suminto resolved IMPALA-10374.
-----------------------------------
Fix Version/s: Impala 4.0
Resolution: Fixed
Closing this Jira now since the fix has been merged.
> Limit page iteration at BufferedTupleStream::DebugString()
> ----------------------------------------------------------
>
> Key: IMPALA-10374
> URL: https://issues.apache.org/jira/browse/IMPALA-10374
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 3.4.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Minor
> Labels: newbie, ramp-up
> Fix For: Impala 4.0
>
>
> BufferedTupleStream::DebugString() iterate std::list<Page> that can
> potentially grow very large. While most references to this method are behind
> DCHEK logging (thus stripped in release build), one of them is used to build
> Status message through call to GroupingAggregator::Partition::DebugString()
> at this line:
> https://github.com/apache/impala/blob/5530b62/be/src/exec/grouping-aggregator-partition.cc#L155
> IMPALA-9851 already cap error message to 128kb at most, but that does not
> eliminate the cost to iterate page list in BufferedTupleStream::DebugString().
> We should limit number of page being iterated in this method to avoid
> unnecessary long string operation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
