[
https://issues.apache.org/jira/browse/IMPALA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Armstrong resolved IMPALA-3675.
-----------------------------------
Assignee: Tim Armstrong
Resolution: Fixed
There are lots of spurious warnings with release builds, dont' think we need to
prioritise fixing them.
> consider turning -Werror on for address sanitizer builds
> --------------------------------------------------------
>
> Key: IMPALA-3675
> URL: https://issues.apache.org/jira/browse/IMPALA-3675
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 2.6.0
> Reporter: Silvius Rus
> Assignee: Tim Armstrong
> Priority: Minor
> Labels: newbie, static-analysis
>
> Currently it seems we're only using -Werror with debug builds.
> The problem is that a number of GCC warnings get issued by the
> analysis/transformation at -O2 or higher. So there could be warnings in our
> release builds that we're simply ignoring.
> We should consider turning -Werror on in release builds. Perhaps have
> another "static-analysis" target that does something like this (and use it in
> GVMs and recommend before submitting code reviews):
> {code}
> g++ ${CXX_FLAGS_RELEASE} -fsyntax-only -Werror -Wfatal-errors ...
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
