Joe McDonnell created IMPALA-11785:
--------------------------------------

             Summary: impala-shell should produce a warning if Thrift's 
fastbinary package isn't working
                 Key: IMPALA-11785
                 URL: https://issues.apache.org/jira/browse/IMPALA-11785
             Project: IMPALA
          Issue Type: Improvement
          Components: Clients
    Affects Versions: Impala 4.3.0
            Reporter: Joe McDonnell


Thrift's fastbinary package accelerates the binary protocol for Thrift with 
native code, and it can make a large difference in performance for impala-shell 
(and other clients). Differences in compilers or other build-time discrepancies 
can cause it to fail to load. When that happens, it falls back to the 
non-accelerated Python code.

Currently, there is no warning when it falls back to the non-accelerated code. 
We should change impala-shell to issue a warning in this case. One way to do 
that is to try to import thrift.protocol.fastbinary and issue a warning if it 
fails to import.
{noformat}
try:
  import thrift.protocol.fastbinary
  print("Successfully imported fastbinary")
except:
  print("Could not import fastbinary"){noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to