Joe McDonnell created IMPALA-13264:
--------------------------------------

             Summary: bin/coverage_helper.sh should always use gcov from the 
toolchain
                 Key: IMPALA-13264
                 URL: https://issues.apache.org/jira/browse/IMPALA-13264
             Project: IMPALA
          Issue Type: Task
          Components: Infrastructure
    Affects Versions: Impala 4.5.0
            Reporter: Joe McDonnell


bin/coverage_helper.sh gets gcov from the toolchain if it is not installed on 
the system.
{noformat}
if ! which gcov > /dev/null; then
  export 
PATH="$PATH:$IMPALA_TOOLCHAIN_PACKAGES_HOME/gcc-$IMPALA_GCC_VERSION/bin"
fi
echo "Using gcov at `which gcov`"{noformat}
Since the toolchain compiler can be different from the system compiler, I think 
it makes more sense to always use gcov from the toolchain's GCC. Then the gcov 
version will always match the GCC version.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to