Joe McDonnell created IMPALA-13352:
--------------------------------------
Summary: Fixup sed separator used to add CFLAGS for TPC-H/TPC-DS
libraries
Key: IMPALA-13352
URL: https://issues.apache.org/jira/browse/IMPALA-13352
Project: IMPALA
Issue Type: Task
Components: Infrastructure
Affects Versions: Impala 4.5.0
Reporter: Joe McDonnell
To build with Clang pointing at our custom GCC, we would need to pass in the
"--gcc-toolchain" CFLAG. Currently, the build scripts for TPC-H and TPC-DS use
"/" as the sed separator. This can't work with CFLAGS that involve directory
locations. We can fix this by using a sed separator that won't be present in
CFLAGS (like #).
{noformat}
# Current
sed -i -r "s/^(CFLAGS\s*=.*)/\1 ${CFLAGS}/" makefile
# Fixed
sed -i -r "s#^(CFLAGS\s*=.*)#\1 ${CFLAGS}#" makefile{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
