[
https://issues.apache.org/jira/browse/IMPALA-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Riza Suminto resolved IMPALA-13400.
-----------------------------------
Resolution: Not A Problem
On second thought, this is not an issue because individual ResourceProfile are
serialized into their own TAggregator.
[https://github.com/apache/impala/blob/7167f3b4f0b6940f36705c95b8da17941557f721/fe/src/main/java/org/apache/impala/planner/AggregationNode.java#L484]
> Incomplete ResourceProfile at multi-class AggregationNode
> ---------------------------------------------------------
>
> Key: IMPALA-13400
> URL: https://issues.apache.org/jira/browse/IMPALA-13400
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
> Affects Versions: Impala 4.4.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> AggregationNode.computeAggClassResourceProfile() call setSpillableBufferBytes
> and setMaxRowBufferBytes. However, ResourceProfile for each aggregation class
> are merged using ResourceProfile.sum() which waive setting both fields.
> [https://github.com/apache/impala/blob/7167f3b4f0b6940f36705c95b8da17941557f721/fe/src/main/java/org/apache/impala/planner/AggregationNode.java#L605]
>
> [https://github.com/apache/impala/blob/7167f3b4f0b6940f36705c95b8da17941557f721/fe/src/main/java/org/apache/impala/planner/ResourceProfile.java#L151]
>
> It should use ResourceProfile.combine() that will pick max
> SpillableBufferBytes and max MaxRowBufferBytes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
