Quanlong Huang created IMPALA-13632:
---------------------------------------
Summary: critique-gerrit-review.py could fail due to
UnicodeDecodeError.
Key: IMPALA-13632
URL: https://issues.apache.org/jira/browse/IMPALA-13632
Project: IMPALA
Issue Type: Bug
Components: Infrastructure
Reporter: Quanlong Huang
Assignee: Quanlong Huang
critique-gerrit-review.py could fail due to UnicodeDecodeError.
{noformat}
$ bin/jenkins/critique-gerrit-review.py --dryrun --revision aefd1b092
Traceback (most recent call last):
File "/home/quanlong/workspace/Impala/bin/jenkins/critique-gerrit-review.py",
line 441, in <module>
merge_comments(comments, get_misc_comments(base_revision, revision,
args.dryrun))
File "/home/quanlong/workspace/Impala/bin/jenkins/critique-gerrit-review.py",
line 200, in get_misc_comments
diff = check_output(["git", "diff", "-U0", "{0}..{1}".format(base_revision,
revision)],
File "/usr/lib/python3.10/subprocess.py", line 421, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "/usr/lib/python3.10/subprocess.py", line 505, in run
stdout, stderr = process.communicate(input, timeout=timeout)
File "/usr/lib/python3.10/subprocess.py", line 1141, in communicate
stdout = self.stdout.read()
File "/usr/lib/python3.10/codecs.py", line 322, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb2 in position 1214326:
invalid start byte{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
