[ 
https://issues.apache.org/jira/browse/IMPALA-13634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Quanlong Huang resolved IMPALA-13634.
-------------------------------------
    Fix Version/s: Impala 4.5.0
       Resolution: Fixed

> ImpalaTestSuite.cleanup_db() should keep the original sync_ddl value
> --------------------------------------------------------------------
>
>                 Key: IMPALA-13634
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13634
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Test
>            Reporter: Quanlong Huang
>            Assignee: Quanlong Huang
>            Priority: Major
>             Fix For: Impala 4.5.0
>
>
> ImpalaTestSuite.cleanup_db() drops the database with sync_ddl=1 by default:
> {code:python}
>   @classmethod
>   def cleanup_db(cls, db_name, sync_ddl=1):
>     cls.client.execute("use default")
>     cls.client.set_configuration({'sync_ddl': sync_ddl})
>     cls.client.execute("drop database if exists `" + db_name + "` 
> cascade"){code}
> https://github.com/apache/impala/blob/b1628d8644d21c3b45acd8b2715a284cf5e8379b/tests/common/impala_test_suite.py#L428-L432
> Without setting back the sync_ddl option, the following tests using 
> cls.client will keep using the same value. The default sync_ddl=1 slows down 
> some tests like TestMetadataQueryStatements.test_describe_db(), and make them 
> lose the test coverage on sync_ddl=0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to