[
https://issues.apache.org/jira/browse/IMPALA-14480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Fehr resolved IMPALA-14480.
---------------------------------
Resolution: Fixed
> Enable Optional OpenTelemetry DCHECKs
> -------------------------------------
>
> Key: IMPALA-14480
> URL: https://issues.apache.org/jira/browse/IMPALA-14480
> Project: IMPALA
> Issue Type: Improvement
> Affects Versions: Impala 5.0.0
> Reporter: Jason Fehr
> Assignee: Jason Fehr
> Priority: Critical
> Labels: opentelemetry
>
> During test runs, the OpenTelemetry tests are proving to be flaky because
> some of the DCHECKs in span-manager.cc were written under the assumption that
> the query lifecycle would deterministically transition between phases. In
> reality, the query lifecycle is not exactly deterministic once the query
> execution begins because multiple threads can be involved in execution,
> result retrieval, query shutdown etc.
> The OTel code is written so that it won't fail in release builds. This
> behavior was verified by running custom cluster and EE tests against release
> builds of Impala.
> Since the DCHECKs provide value by identifying edge cases where the query
> lifecycle does not proceed as expected. Since the code in span-manager.cc is
> written so that situations that would fail a DCHECK do not cause problems in
> release builds, the DCHECKs in span-manager.cc can be ignored during regular
> test runs. Add a method of optionally enabling the DCHECKs in
> span-manager.cc that rely on deterministic query lifecycle transitions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
