Aleksandr Efimov created IMPALA-15081:
-----------------------------------------

             Summary: Improve impala-profile-tool timestamp filter handling
                 Key: IMPALA-15081
                 URL: https://issues.apache.org/jira/browse/IMPALA-15081
             Project: IMPALA
          Issue Type: Improvement
            Reporter: Aleksandr Efimov
            Assignee: Aleksandr Efimov


impala-profile-tool supports --min_timestamp and --max_timestamp for filtering
profile log entries by the timestamp prefix. The current upstream profile log
writer prefixes entries with UnixMillis(), but the tool help only describes the
filter value as an "integer timestamp" and parse errors do not explain the
expected unit.

IMPALA-14099 also surfaced a profile-log-like entry with an oversized,
non-canonical timestamp token. The immediate fix for IMPALA-14099 intentionally
keeps the existing int64 timestamp-filter behavior and only avoids rejecting the
profile payload when timestamp filters are not requested.

This follow-up tracks making timestamp handling clearer and more useful.

Proposed scope:
- Document that --min_timestamp and --max_timestamp expect Unix epoch
milliseconds.
- Improve diagnostics when timestamp filters are requested but an entry's
timestamp token is invalid or out of range.
- Investigate where high-precision or non-canonical timestamp tokens like the
one from IMPALA-14099 come from.
- Consider adding human-readable filters such as --min_time/--max_time with
ISO-8601 UTC input.
- If real profile logs use microsecond or nanosecond epoch timestamps, consider
explicit timestamp unit handling rather than silently guessing units.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to