Stamatis Zampetakis created IMPALA-15509:
--------------------------------------------
Summary: Improve usability for Devcontainer
Key: IMPALA-15509
URL: https://issues.apache.org/jira/browse/IMPALA-15509
Project: IMPALA
Issue Type: Task
Reporter: Stamatis Zampetakis
Assignee: Jason Fehr
The Impala Devcontainer can be found in
https://hub.docker.com/r/apache/impala-dev
The instructions
[link|https://github.com/jasonmfehr/impala/blob/devcontainer-stable/.devcontainer/README.md]
points to jasonmfehr fork repository but ideally it should point to the
official [ASF
repository|https://github.com/apache/impala/blob/master/.devcontainer/README.md].
The README.md file contains instructions on how to dowlonad/pull the image but
it does not indicate the most typical commands on how to run it. Something like:
{code:bash}
$ docker run -it --name impala-dev apache/impala-dev:stable
{code}
I suppose the expectation is to go through devcontainers/cli but if its
possible to avoid that step and use directly docker it would remove one
installation prerequisite. By doing so, we could also remove "retrieve the
necessary config files" step which makes things slightly confusing as we have
two clones of the repo (one in the container and one partial in the host).
In the Configuration section it mentions to use the "restart-minicluster"
command to spin up dependent services but the alias from zshrc is not active
since the default entrypoint does not launch a zsh shell. Clarifying the
suggested {{docker run}} command or modifying the entrypoint to launch zsh
should address this issue.
When the container starts Postgres and SSH are not running so calling
restart-minicluster will fail. A call to .devcontainer/entrypoint.sh is
possibly missing from somewhere.
Personally, I am connecting the IDE to the dev container using SSH so starting
the service and exposing the SSH port would be convenient.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
