[ 
https://issues.apache.org/jira/browse/IMPALA-5622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Armstrong resolved IMPALA-5622.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.10.0

Resolving since the only remaining case is a pre-existing gap. I tested it 
manually and confirmed that it works as expected. See IMPALA-5780

> Ensure test coverage for spilling disabled for all spilling operators
> ---------------------------------------------------------------------
>
>                 Key: IMPALA-5622
>                 URL: https://issues.apache.org/jira/browse/IMPALA-5622
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Infrastructure
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>             Fix For: Impala 2.10.0
>
>
> We should ensure that we have test coverage for disabling spilling. There are 
> two dimensions. I don't think we need coverage of the whole matrix, but we 
> need coverage along both dimensions.
> Query operators:
> * Agg - covered by TestScratchLimit 
> * Hash join - covered by TestScratchLimit  (and with in-review IMPALA-5570 
> patch)
> * Sort - covered by TestScratchLimit and TestScratchDir
> * Analytic - covered by TestScratchLimit 
> Means of disabling:
> * scratch_limit = 0 - covered by TestScratchLimit
> * disable_unsafe_spills = true + a table missing stats - NOT COVERED
> * starting up with no scratch disks - covered by TestScratchDir



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to