Tim Armstrong created IMPALA-5823:
-------------------------------------
Summary: SET_DENY_RESERVATION_PROBABILITY debug action is not
always effective
Key: IMPALA-5823
URL: https://issues.apache.org/jira/browse/IMPALA-5823
Project: IMPALA
Issue Type: Sub-task
Components: Backend
Affects Versions: Impala 2.10.0
Reporter: Tim Armstrong
Assignee: Tim Armstrong
Priority: Critical
The debug action is only effective if the client is already registered. In many
cases this is not true because buffer pool client registration was deferred
until later in Open() as part of the IMPALA-4862 changes.
{code}
if (buffer_pool_client_.is_registered()) {
// Parse [0.0, 1.0] probability.
StringParser::ParseResult parse_result;
double probability = StringParser::StringToFloat<double>(
debug_action_param_.c_str(), debug_action_param_.size(),
&parse_result);
if (parse_result != StringParser::PARSE_SUCCESS || probability < 0.0
|| probability > 1.0) {
return Status(Substitute(
"Invalid SET_DENY_RESERVATION_PROBABILITY param: '$0'",
debug_action_param_));
}
buffer_pool_client_.SetDebugDenyIncreaseReservation(probability);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
