[
https://issues.apache.org/jira/browse/IMPALA-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Armstrong resolved IMPALA-5570.
-----------------------------------
Resolution: Fixed
Fix Version/s: Impala 2.10.0
IMPALA-5570: fix spilling null-aware anti join
IMPALA-4672: Part 2 regressed NAAJ by tightening up the spilling
invariants (e.g. can't unpin with spilling disabled) but we
didn't have tests for spilling NAAJs that could detect the
regression. This patch adds those tests, fixes the regressions,
and improves NAAJ by reliably spilling the probe side and not
trying to bring the whole probe side into memory.
The changes are:
* All null-aware streams start off in memory and are only unpinned if
spilling is enabled.
* The null-aware build partition can be spilled in the same way as hash
partitions.
* Probe streams are unpinned whenever there is memory pressure - if
spilling is enabled and either a build partition is spilled or
appending to the probe stream fails.
* Spilled probe streams are not re-pinned in EvaluateNullProbe().
Instead we just iterate over the rows of the stream.
Testing:
Add query tests where the three different buckets of rows are large
enough to spill: the build and probe of the null-aware partition and the
null probe rows.
Test both spilling and in-memory (with spilling disabled) cases.
Change-Id: Ie2e60eb4dd32bd287a31479a6232400df65964c1
Reviewed-on: http://gerrit.cloudera.org:8080/7367
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Impala Public Jenkins
> Ensure that NAAJ works with spilling enabled and disabled.
> ----------------------------------------------------------
>
> Key: IMPALA-5570
> URL: https://issues.apache.org/jira/browse/IMPALA-5570
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend
> Affects Versions: Impala 2.10.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Critical
> Labels: resource-management
> Fix For: Impala 2.10.0
>
>
> I believe there are some gaps in test coverage here:
> * Should be able to run a large NAAJ with spilling disabled (need to test
> both success and OOM cases)
> * Test spilling cases:
> - null_probe_rows_ does not fit in memory
> - null_aware_probe_partition_ does not fit in memory along with other
> partitions
> - null_aware_partition_ does not fit in memory along with other partitions
> We should address these gaps before releasing the new buffer pool code to
> ensure we don't regress anything.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
