[
https://issues.apache.org/jira/browse/JCLOUDS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-283.
------------------------------------
Resolution: Won't Fix
After some conversations, we found that this change won't fix the real issue,
when the images don't have the bash shell installed. Migrating the existing
code to a more common shell was discarded, so this patch is not going to be
merged.
The details and conclusions of what was discussed are summarized in the pull
request comments.
> Don't use bash shopt in the wrapper script
> ------------------------------------------
>
> Key: JCLOUDS-283
> URL: https://issues.apache.org/jira/browse/JCLOUDS-283
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-scriptbuilder
> Affects Versions: 1.6.2
> Reporter: Ignasi Barrera
> Assignee: Ignasi Barrera
> Fix For: 1.7.0
>
>
> Some images with a bash shell don't support the "shopt" command used in the
> wrapper script, so it should be removed to make the generated scripts more
> portable. Some default devstack images don't support the command (see [1]),
> so fixing this may help significantly testing jclouds with openstack.
> The used at the moment are:
> * xpg_echo: Turns on/off the interpretation of the backslash (to interpret or
> not the '\n', for example).
> * expand_aliases: Turns on/off the alias expanding. This allows to define
> alias in the script and use them later.
> The first one can be removed, if all calls to the "echo" command that need to
> interpret the backslash are changed to "echo -e".
> The second one, could be removed if the alias definitions are replaced by
> bash functions, which should be a direct change.
> [1] http://apache.markmail.org/thread/n4dna3rmapcj42o3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
