cygri opened a new issue, #1309:
URL: https://github.com/apache/jena/issues/1309

   [This 
line|https://github.com/apache/jena/blob/b74e7fab67f368b6152e033a6a19c47dfcbbdd10/jena-arq/src/main/java/org/apache/jena/sparql/engine/ref/RefEval.java#L80]:
   ```
   List<Binding> list = new ArrayList<>((int)dsg.size()) ;
   ```
   But according to the Javadoc for `DatasetGraph.size()`:
   ```
   /** Get the size (number of named graphs) - may be -1 for unknown */
   ```
   So `-1` should be expected and treated specially to avoid a potential 
`IllegalArgumentException` for negative initial size.
   
   (We do not use `RefEval` and I have not seen this exception actually occur. 
I noticed the potential problem when nosing around the source code, looking at 
callers of `DatasetGraph.size()`.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to