sszuev commented on issue #1374: URL: https://github.com/apache/jena/issues/1374#issuecomment-1153891201
> > But replacing `QueryExecutionFactory.create(query, data.getGraph(), context)` (from PR) with the expression `QueryExecution.create().query(query).model(data).context(context).build()` causes test error (where query is `String`, not `Query`). > > Visual inspection only but this looks odd. The PR new `create(query, graph, context)` uses `DatasetGraphWrapper` to apply the context. But I don't see this going to the `QueryExecDatasetBuilder`. Dataset contexts are usually added to the context being built for the query (`Context.mergeCopy`), not a replacement. `DatasetGraphWrapper(,Context)` hides the wrapped dataset's context. I think, `QueryExecutionFactory.create(query, data.getGraph(), context)` can be removed from PR, and new bug for `QueryExecution.create().query(query).model(data).context(context).build()` with tests attached can be started. @afs ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
