new-javacc commented on issue #1324: URL: https://github.com/apache/jena/issues/1324#issuecomment-1176299836
> [javacc/javacc#85](https://github.com/javacc/javacc/pull/85) has not been integrated into javacc releases. > > Jena running it's own fork of javacc is highly undesirable - it's technical debt. Users must be able to build Jena and while we ship the generated code in a Jena release so uses don't have to run javacc themselves (e.g. only old versions are available in Ubuntu app repos) they should be able to. > Not sure why you needed to fork. Let me know if there is something that I can do to help with that. If the issue is with CharStream, just set USER_CHAR_STREAM=true and write your own stream class that does better buffer management. But like I said most often it's grammar inefficiencies that manifest this way. And use ideas like lexical states to more elegantly handling huge tokens. > I'm not even sure [javacc/javacc#85](https://github.com/javacc/javacc/pull/85) is the right solution - it has access overhead. Maybe that's why `ArrayList` grows by 1.5 each step. > Not sure what this is. I don't think we merged into main I will check. > The case of 100Mb literals in a query is not mainstream smile . (Maybe search by SHA512?) It's not unheard of. But if you expect this to happen even occasionally (as opposed to rarely), you might want to redo your rule for literals. Negation opreator does generate a lot of overhead in terms of state etc. > > #1328 (JavaCC 7.0 upgrade) is in Jena/main. > > (Background: the main RIOT parsers do not use JavaCC.) > > `ContentIllegalInProlog` is an XML error. Maybe it should not have the `?xml` part. RDF XML Literals do not have the `<?xml>`. If you change your example to an rdf:XMLLiteral, there is a warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
