afs commented on issue #1498:
URL: https://github.com/apache/jena/issues/1498#issuecomment-1231307271

   No code calls the PrefixMNapping2 constructors so we can be delete it.
   
   It says "Updates go to the local (second) copy only". It is (was) for 
locally extending prefixes mapping. In particular, it does not alter the global 
pmap which would be a concurrency problem.
   
   And if you'd let the code through, you'd find PrefixMapping.Extended is 
immutable. 
   
   
   The general solution is a buffering prefix map (records diffs). 
[BufferingPrefixMap](https://github.com/afs/jena-workspace/blob/main/src/main/java/dsg/buffering/BufferingPrefixMap.java).
   Sounds like what you want is the "add only" temporary extensions version of 
that.
   
   NB `PrefixMap` vs `PrefixMapping`.
     
   As a general point on 
[JENA-2309](https://issues.apache.org/jira/browse/JENA-2309) -- Jena has many 
interfaces. Tweaking implementations for one use case needs to be balanced with 
having clear code for general use (the majority of Jena users). 
One-impl-does-everything can be hard to maintain. Not everything is a bug.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to