afs commented on issue #2046: URL: https://github.com/apache/jena/issues/2046#issuecomment-1772544910
@tomdw Which form/packging of Fuseki are you using? Ensuring `FusekiModule` get triggered for dynamically added datasets will be necessary anyway but maybe the Prometheus code should cope with a changing `DataAccessPointRegistry`. That also means a fix now is possible whereas changing the `FusekiModule` interface has to be done very carefully and that means longer timescale. Logically, the metrics should be generated every time a metrics response is generated. An optimization is that the Prometheus code caches setup some where around `FusekiRequestsMetrics` and resets when there is a change in `DataAccessPointRegistry`. `DataAccessPointRegistry` would have a UUID for each setup (the epoch) and it changes the UUID when a change is made. No harm in being safe - e.g. reset the UUID if a change _may_ have been made. The UUID approach is safer than relying on the names via `DataAccessPointRegistry.accessPoints` although that is an option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
