afs commented on issue #3589: URL: https://github.com/apache/jena/issues/3589#issuecomment-3732669654
I'm getting closer to changing the license headers. For the actual change, but after that, the `com.mycila:license-maven-plugin` can be used to check (probably not automatically as its handling of sub-modules seems to require absolute file names). I haven't manged to get the plugin to make the change. It does not put in a blank line after the license, before `package ...`. #3589 went though the code base and made all the license headers the same bytes exactly. The next choice is the exact bytes of the new header. There are two choices - differing only on the length of lines. Both styles are in use in Apache projects. Jena currently has hybrid (see issue description) - short-line first paragraph and long-line second paragraph. https://www.apache.org/legal/src-headers.html is the Foundation policy text. Using https is acceptable. Realistically, only java files will be changed for Jena 6.0.0, not POMs or scripts. Making the change needs great care and it's time consuming. POMs should be simple (already one layout and no variations); scripts probably do have byte-level variations. Longer line form: 75 columns 16 lines ``` /* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. * * SPDX-License-Identifier: Apache-2.0 */ ``` Alternative: formatted for short lines and 2 lines longer. 62 columns 18 lines ``` /* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. * * SPDX-License-Identifier: Apache-2.0 */ ``` For reference, the exclusions for java are: | | | |-----|----| `org/apache/jena/sparql/lang/sparql_10` | SPARQL 1.0 Parser - generated `org/apache/jena/sparql/lang/sparql_11` | SPARQL 1.1 Parser - generated `**/org/apache/jena/ext` | Source code from other projects, e.g Xerces (all AL2) `**/javacc` | All active javacc code now goes into a `javacc` directory `org/apache/jena/riot/thrift/wire` | Thrift generated `org/apache/jena/web/HttpSC.java` | Code from Eclipse Jetty `org/apache/jena/fuseki/servlets/CrossOriginFilter.java` | Code from Eclipse Jetty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
