afs commented on issue #3751:
URL: https://github.com/apache/jena/issues/3751#issuecomment-3898841378

   @Aklakan 
   
   Is there any reason not to put try-catch-QueryIterFailed around the whole of 
`optimizeExecute` bodies?
   
   This
   ```java
        if ( ! input.hasNext() )
               return input ;
   ```
   isn't necessary but, generally, the pattern of having a quick check to make 
sure there is something to do is used.
   
   ---
   
   A short test case is:
   
   ```sparql
   PREFIX :  <http://example/>
   
   SELECT *
   WHERE {
        ?x :property* ?y .
        ?y :q1 123 .
        ?y :q2 456 .
   }
   ```
   even on an empty database. The key is a non-matching, non-mergable pattern 
then 2+ triples patterns - even `{ FILTER(false) }` will do.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to