afs commented on issue #3755: URL: https://github.com/apache/jena/issues/3755#issuecomment-3909690159
> Isn't this the logic that is effectively already in place in QueryIteratorBase Yes, the illustration was to keep it within `QueryIterPlainWrapper`. We may be able to do all the work in the QueryIterator hierarchy - having reviewed the current code, it feel like there is some duplication. Checking lower down is needed if a QueryIterator does a significant amount of compound work in a `hasNextBinding`/`moveToNextBinding` step. A review of all QueryIterators would be worthwhile. There is probably also making `requestCancel` concrete, and not abstract. Some places need it, but quite a few don't. And call it `cancelRequested`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
